html-parse-stringify2 icon indicating copy to clipboard operation
html-parse-stringify2 copied to clipboard

Published 20 hours ago • verified publisher icon rayd

Last boolean attr add

Open MurakamiKennzo opened this issue 6 years ago • 3 comments

close #15

MurakamiKennzo avatar Aug 30 '18 12:08 MurakamiKennzo

HI, @rayd I am happy you can reply me , but since I am greener here and can you tell me how to find failed check? and what should I do ? thanks.

MurakamiKennzo avatar Aug 30 '18 12:08 MurakamiKennzo

Hi @MurakamiKennzo, thanks for the fix! Would you mind adding a test to verify the fix?

I think the Travis CI failure is because I've configured it incorrectly. I will try to get this fixed.

rayd avatar Aug 31 '18 06:08 rayd

yes, i try to add test similar as your test code in parse-tag.js. but I cannot run npm test. since I am unfamiliar with zuul,. so I cannot fix it and push code.

DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

it seems node deprecated api bug and configured incorrectly caused. waiting....

MurakamiKennzo avatar Aug 31 '18 13:08 MurakamiKennzo