extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Published 20 hours ago • verified publisher icon raycast

[1Password] Password not copied if biometric step is required

Open gshpychka opened this issue 2 years ago • 11 comments
trafficstars

Extension

https://www.raycast.com/khasbilegt/1password

Description

The "copy password" action does not copy the password if the 1P app prompts for Biometric authentication. It should copy the password after successful authentication.

Steps To Reproduce

  1. Enable TouchID protection in 1Password settings.
  2. Use this extension's "copy password" feature
  3. You will be prompted by 1Password to authenticate with TouchID, complete the authentication
  4. Confirm that the password was not copied

Current Behaviour

Password not copied after completing biometric auth, you have to perform the action again to actually get the password.

Expected Behaviour

Password copied after completing biometric auth

gshpychka avatar Oct 29 '23 09:10 gshpychka

Thank you for opening this issue!

🔔 @khasbilegt @thomaspaulmann @dteare @pernielsentikaer @cb372 @Davidwalser @henrik-dmg @justspacedog you might want to have a look.

💡 Author and Contributors commands

The author and contributors of khasbilegt/1password can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopen the issue.

raycastbot avatar Oct 29 '23 09:10 raycastbot

@khasbilegt, will you be able to look into this? 🥺

andreiborisov avatar Dec 12 '23 16:12 andreiborisov

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot avatar Jan 31 '24 16:01 raycastbot

This is still an issue.

gshpychka avatar Jan 31 '24 17:01 gshpychka

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

raycastbot avatar Mar 21 '24 18:03 raycastbot

@khasbilegt this is still an issue

gshpychka avatar Mar 21 '24 18:03 gshpychka

Hello, I am working on some updates of the app, right now focused only on v8. Which version of 1Password are you using?

luizvergennes avatar Apr 08 '24 11:04 luizvergennes

Hello, I am working on some updates of the app, right now focused only on v8. Which version of 1Password are you using?

Using latest v8

gshpychka avatar Apr 09 '24 07:04 gshpychka

With the latest release, you can enable the "Auto Renew Authorization" background refresh, resulting in fewer biometric prompts. Additionally, now users are always prompted when retrieving items, not during copying any fields. Which should remove your frustration. Let me know how you feel.

luizvergennes avatar Apr 09 '24 11:04 luizvergennes

With the latest release, you can enable the "Auto Renew Authorization" background refresh, resulting in fewer biometric prompts. Additionally, now users are always prompted when retrieving items, not during copying any fields. Which should remove your frustration. Let me know how you feel.

With that setting enabled, I now get a biometrics prompt every ~ten minutes (maybe more?).

I don't mind getting a prompt when copying a password - the issue is that the password is not copied after I confirm my biometrics - I have to launch raycast again afterwards. Same with the new behavior - I now get prompet when the extension loads (instead of when the password is copied), but this closes raycast and I have to launch it again.

gshpychka avatar Apr 11 '24 08:04 gshpychka

With that setting enabled, I now get a biometrics prompt every ~ten minutes (maybe more?).

It should be at each 9 minutes. If for these 9 minutes the computer stays awake, it should not ask for a password. Can you confirm if on your 1Password config, it is set to lock after 10 or more minutes? Right now my auto lock is set to 4 hours. And lock on sleep enabled as well.

luizvergennes avatar Apr 11 '24 12:04 luizvergennes

With that setting enabled, I now get a biometrics prompt every ~ten minutes (maybe more?).

It should be at each 9 minutes. If for these 9 minutes the computer stays awake, it should not ask for a password. Can you confirm if on your 1Password config, it is set to lock after 10 or more minutes? Right now my auto lock is set to 4 hours. And lock on sleep enabled as well.

Yeah I believe that's the behavior I'm seeing. I don't want random prompts out of nowhere. I am fine with getting a prompt when opening the extension or copying a password - I just don't want the extension to close after I confirm the prompt, so that I have to open it again.

gshpychka avatar Apr 12 '24 08:04 gshpychka

I see, I recommend then you disabling the auto-renew command on the Raycast settings to stop these random prompts. I think have a fix in progress for this. But I will need you to wait a bit more, since it will include another commands I am working on.

luizvergennes avatar Apr 12 '24 11:04 luizvergennes

I see, I recommend then you disabling the auto-renew command on the Raycast settings to stop these random prompts. I think have a fix in progress for this. But I will need you to wait a bit more, since it will include another commands I am working on.

Of course, thank you

gshpychka avatar Apr 12 '24 20:04 gshpychka

Hi, I wanted to jump in on this as I've been seeing the same issue for a while now, but it is a bit different. In my set up, I have the auto-renew turned off, and I get two TouchID prompts every time I try to see a password, and then Raycast closes without the password copied. I then have to go back and get the password again.

jmabeebiz avatar Apr 25 '24 21:04 jmabeebiz

Hi, I wanted to jump in on this as I've been seeing the same issue for a while now, but it is a bit different. In my set up, I have the auto-renew turned off, and I get two TouchID prompts every time I try to see a password, and then Raycast closes without the password copied. I then have to go back and get the password again.

Yeah, that's the same issue.

gshpychka avatar Apr 26 '24 07:04 gshpychka

I have a PR waiting on merge, for some improvements and fixes. Sadly I don't think it will have any impact on this issue, will wait on your feedback. If you can provide me what is your workflow I can maybe simulate it?

luizvergennes avatar May 03 '24 18:05 luizvergennes

All good. I changed my workflow and added the extension back in Arc, no need for passwords as much in Raycast now.

Thanks, // Justin Mabee Squarespace Designer | Available for Hire justinmabee.com ( http://justinmabee.com ) (267) 632-4103

Sent via Superhuman iOS ( @.*** )

On Fri, May 3 2024 at 2:32 PM, Luiz Gustavo Marcondes < @.*** > wrote:

I have a PR waiting on merge, for some improvements and fixes. Sadly I don't think it will have any impact on this issue, will wait on your feedback. If you can provide me what is your workflow I can maybe simulate it?

— Reply to this email directly, view it on GitHub ( https://github.com/raycast/extensions/issues/9012#issuecomment-2093550434 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AR3XJS2TTWAJHHK7KC5SPZTZAPJ2DAVCNFSM6AAAAAA6UW33ESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGU2TANBTGQ ). You are receiving this because you commented. Message ID: <raycast/extensions/issues/9012/2093550434 @ github. com>

jmabeebiz avatar May 03 '24 18:05 jmabeebiz

I have a PR waiting on merge, for some improvements and fixes. Sadly I don't think it will have any impact on this issue, will wait on your feedback. If you can provide me what is your workflow I can maybe simulate it?

Sure! Just basically set the primary action to "Copy password" and try to use the plugin 10 minutes after last auth. Expected behavior: Auth prompt -> Password is copied. Actual beavior: Auth prompt -> Nothing happens. Have to launch the plugin again and repeat the process to actually copy the password.

gshpychka avatar May 05 '24 20:05 gshpychka

With the latest update for the extension now, the biometric steps are invoked on extension start. Which solves this issue.

@raycastbot close this issue

luizvergennes avatar May 21 '24 13:05 luizvergennes