extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Update tc-no-generator extension

Open 0xdhrv opened this issue 2 months ago • 3 comments

Description

  • Standardized keyboard shortcuts and removed an unsupported Save shortcut to fix a build error.
  • Added a loading indicator for history to avoid flicker and moved "Delete All" into item actions; top-level now only has Refresh.
  • Updated README for clearer commands, shortcuts, and privacy, and refreshed package metadata, dependencies, and tooling.

Screencast

https://github.com/user-attachments/assets/2b7eadf8-b954-4633-af4b-9eec8604e158

Checklist

0xdhrv avatar Dec 19 '25 09:12 0xdhrv

Thank you for your contribution! :tada:

🔔 @denizyoldas you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

📋 Quick checkout commands
BRANCH="ext/tc-no-generator"
FORK_URL="https://github.com/0xdhrv/raycast-extensions.git"
EXTENSION_NAME="tc-no-generator"
REPO_NAME="raycast-extensions"

git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run dev

Due to our current reduced availability, the initial review may take up to 10-15 business days.

raycastbot avatar Dec 19 '25 09:12 raycastbot

@greptileai, could you please do a fresh review of this PR?

0xdhrv avatar Dec 22 '25 19:12 0xdhrv

Greptile Summary

This PR modernizes the Turkish ID generator extension by converting commands from no-view to view mode, adding a history feature, and updating tooling. The changes include standardized keyboard shortcuts, improved UX with loading indicators, and updated dependencies.

Key Changes:

  • Converted tc-no-generate from no-view to view mode with preview before copying
  • Added new tc-history command to view/manage generated IDs (replaces last-tc)
  • Auto-saves generated IDs to history on component mount
  • Updated to modern ESLint flat config and ES2023
  • Comprehensive README rewrite from Turkish to English

Issues Found:

  • README documentation references deleted last-tc command that no longer exists (lines 13-15)
  • tc-no-generate.tsx has redundant "Save as Last" action that duplicates the auto-save logic already running in useEffect

Confidence Score: 2/5

  • This PR has documentation errors and redundant code that should be fixed before merging
  • While the core functionality and modernization changes are solid, there are two clear issues: (1) README incorrectly documents a last-tc command that was deleted, causing user confusion, and (2) redundant "Save as Last" action that duplicates existing auto-save behavior. These are not critical bugs but affect user experience and code quality.
  • Pay attention to README.md (outdated command references) and src/tc-no-generate.tsx (redundant action)

Important Files Changed

Filename Overview
extensions/tc-no-generator/package.json Updated metadata, dependencies, and added new history command - all changes look good
extensions/tc-no-generator/src/tc-no-generate.tsx Converted to view mode with history saving; has redundant "Save as Last" action duplicating auto-save logic
extensions/tc-no-generator/README.md Documentation out of sync - references deleted last-tc command that no longer exists

greptile-apps[bot] avatar Dec 22 '25 19:12 greptile-apps[bot]

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

raycastbot avatar Jan 06 '26 19:01 raycastbot