extensions
extensions copied to clipboard
raycast
[1Password] Extension showing items in search for empty vault
Extension – 1Password
Author:
Description
Steps To Reproduce
- Add multiple vaults to 1Password
- Remove items from that vault
- Items are still visible when searching via the extension
The current behavior
Deleted items are still visible in search (sorry for all the blurring, this is a work account and client names are sometimes secret:
The expected behavior
Deleted items should not appear in search
Raycast version
v1.36.0
Let me know if you need more info. The repro steps may not be exactly accurate as someone else on my team moved all items from the indicated vault to another so I'm not sure exactly how they did that. All I know is that search is showing results for an empty vault (see screenshots)
EDIT: CLI is showing no results as well:
@pernielsentikaer any suggestions? I'm still seeing old/removed entries and nothing I have tried will cause an update in the extension. In fact, the entire vault has been renamed but still shows up as the old name.
Same problem here. The deleted entries show up in the 'Recently deleted items' that can be found in the menu for the desktop app. Raycast should probably not be querying these items.
That sounds like a bug to me, I can take a look within a few days if @dteare don't beat me 🙂
This issue/pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean. Thanks for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
I couldn't find a way to determine if the item was in the trash, is that possible @dteare
Hello @pernielsentikaer, @ShiftyMcCool. I am currently rewriting the extension utilizing the 1Password CLI 2 and this issue will be addressed in the new version. Thanks.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊
Just got a notification that this went stale. This is just a comment to bump and ask about progress. Thanks!
Sorry for the late reply. I get too many notifications.
The screenshot in the OP is from 1Password 7. With 1Password 8 the CLI is used to provided the needed information to Raycast, and by default archived (a.k.a. trashed) items are not included. Upgrading to 1Password 8 and following the setup instructions for opbookmarks will get you up-to-date and resolve this issue. As @khasbilegt mentioned there will be an update to this extension in the future that will integrate with the 1Password CLI directly and avoid the setup & refresh steps.
As for 1Password 7, I believe there's a trashed flag in the metadata files that could be used to filter them out. To do this one would need to add an optional trashed attribute here and then filter out trashed items when constructing the item list cache, probably here.
I hope that helps. Cheers!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊
I'm closing this due to inactivity; feel free to comment in the thread when you're ready to continue working on it 🙂 You can also catch us in Slack if you want to discuss.