extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Add unifi-network extension

Open lewjuh opened this issue 1 year ago • 1 comments

Description

Screencast

Checklist

lewjuh avatar Jan 12 '25 18:01 lewjuh

Congratulations on your new Raycast extension! :rocket:

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

raycastbot avatar Jan 12 '25 18:01 raycastbot

Hi 👋

Did you see the UniFi extension before creating this?

Hey! Ah, sadly I did not. This does differ in that it uses the official UniFi API recently released, but understand if dups aren't wanted in the store.

lewjuh avatar Jan 22 '25 12:01 lewjuh

Hi @lewjuh 👋

I spoke with the author of the other extension, he is willing to let you take over the ownership of current and update it with your code - could you do that instead of opening a new? Feel free to change author too when you do

Do you have any questions?

pernielsentikaer avatar Jan 23 '25 20:01 pernielsentikaer

Hi @lewjuh 👋

I spoke with the author of the other extension, he is willing to let you take over the ownership of current and update it with your code - could you do that instead of opening a new? Feel free to change author too when you do

Do you have any questions?

@pernielsentikaer Hey, thanks for sorting that, I appreciate it!

Happy to do that, is there any concern about people who have the old version installed? How does the updating work on raycast extensions for a user?

lewjuh avatar Jan 27 '25 10:01 lewjuh

Let's see if we can come up with a way. We should follow the best approach by using an API key, as you're doing, instead of relying on a username/password. We could make the new preference required and remove the two other preferences; that will force the user to add the key.

Another option is to set the new preference as optional and show a special view to let the user know about the change and guide them a bit better on how to do that.

The second approach could be a cool thing, but it might be overkill.

pernielsentikaer avatar Jan 28 '25 09:01 pernielsentikaer

@pernielsentikaer Will look at doing the latter, to try make it as easy as possible!

Have updated and refactored this for now as needed some extra function.

lewjuh avatar Jan 31 '25 18:01 lewjuh

So is this already ready for review?

pernielsentikaer avatar Feb 03 '25 20:02 pernielsentikaer

So is this already ready for review?

Sorry nope, just refactored and added to my code, i need to look at the other extension to see how best to integrate it.

lewjuh avatar Feb 03 '25 21:02 lewjuh

Awesome, thanks for checking. Since we're taking it over, it's nice if we can do it as softly as possible 😊

pernielsentikaer avatar Feb 04 '25 08:02 pernielsentikaer

@pernielsentikaer Hey mate, wasnt sure how exactly to go about updating the other one but just went and directly updated it. #17101

Let me know if thats okay, i went for the option of prompting to update the user but still having the legacy stuff work. Can probably close this now and move over to their to review.

lewjuh avatar Feb 16 '25 06:02 lewjuh

Closing this in favor of https://github.com/raycast/extensions/pull/17101

pernielsentikaer avatar Feb 23 '25 07:02 pernielsentikaer