extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Add `Ghostty` support to terminal finder

Open AnirudhG07 opened this issue 11 months ago • 8 comments

Description

I have added Ghostty support for terminal finder extension. I have added source codes, changed CHANGELOG.md and package.json appropriately as mentioned in DOCS. Closes #16070

Screencast

https://github.com/user-attachments/assets/7c48f290-c1b3-4d44-b209-7cd9648bf17b

https://github.com/user-attachments/assets/208051f0-3ae1-438e-89e8-75d9f4c0ca9e

Note that the shifts in panes are due to aerospace.

Checklist

AnirudhG07 avatar Dec 29 '24 07:12 AnirudhG07

Thank you for your contribution! :tada:

🔔 @yedongze @Bibabidu you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days 🎄

raycastbot avatar Dec 29 '24 07:12 raycastbot

You need to add your Raycast handle in contributors, not your GitHub 🙂

pernielsentikaer avatar Jan 09 '25 04:01 pernielsentikaer

@pernielsentikaer I have changed the handle to raycast one. If anything else it left, pls let me know. We can merge this(and my other one)! Thanks :)

AnirudhG07 avatar Jan 09 '25 08:01 AnirudhG07

It looks like there is only one error left, Command failed with ENOENT: prettier 'src/**' '!**/.DS_Store' --list-different Can you try running Prettier on the source code?

janosorcsik avatar Jan 09 '25 11:01 janosorcsik

@janosorcsik, I ran the below command in the terminal finder extension directory.

❯ prettier 'src/**' '!**/.DS_Store' --list-different

❯

Nothing particular output came or any file changed(checked git). Please share what else to do.

AnirudhG07 avatar Jan 09 '25 12:01 AnirudhG07

Can you, @AnirudhG07 try adding Prettier to devDependencies in the package.json file? "prettier": "^3.1.1", The CLI workflow has changed and this might be causing the error.

janosorcsik avatar Jan 09 '25 20:01 janosorcsik

@janosorcsik I had added prettier as you said. also updated package-lock.json. :)

AnirudhG07 avatar Jan 10 '25 04:01 AnirudhG07

It doesn't open any directory in Ghostty, it just opens Ghostty. Could you check if it works as expected?

pernielsentikaer avatar Jan 12 '25 06:01 pernielsentikaer

@pernielsentikaer It works just fine for me. If I am somewhere in ghostty, I can perfectly open that same dir in finder. If I am somewhere in finder, I can perfectly open ghostty present in that dir.

AnirudhG07 avatar Jan 14 '25 09:01 AnirudhG07

I'm not sure if I tested it on another machine, but it works as expected now 🤔

pernielsentikaer avatar Jan 15 '25 10:01 pernielsentikaer

Published to the Raycast Store: https://raycast.com/yedongze/terminalfinder

github-actions[bot] avatar Jan 15 '25 10:01 github-actions[bot]

:tada: :tada: :tada:

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

raycastbot avatar Jan 15 '25 10:01 raycastbot