extensions icon indicating copy to clipboard operation
extensions copied to clipboard

[Airtable] update the OAuth ID to fix login not working (scope mismatch)

Open xmok opened this issue 1 year ago • 1 comments

Description

This will close #15159 and fix the scope issue by replacing the ID with a new one. The Airtable Team hasn't update the scopes yet so we switch to another one that has proper scopes. I have mentioned it in README so if future changes are needed, one knows who to reach out to.

I have added comments for the logic of hard coding OAuth IDs and checking them.

Screencast

N/A - logs in fine.

Checklist

xmok avatar Oct 29 '24 19:10 xmok

Thank you for your contribution! :tada:

🔔 @marks @SeanKeenan-at @pernielsentikaer you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

raycastbot avatar Oct 29 '24 19:10 raycastbot

@marks, could you take a look here? I don't use Airtable myself

pernielsentikaer avatar Nov 04 '24 08:11 pernielsentikaer

I do not use Airtable anymore either. At quick glance, this change looks fine, though I think it would have been better to have Airtable update the existing OAuth app :\ (but it seems @xmok tried and hence the need for this PR)

marks avatar Nov 04 '24 15:11 marks

I'll send another email as maybe the first one got drowned in other threads?

It makes sense to use the OG OAuth App as it doesn't break UX. The only reason I can think of for a new App is so it's easier/quicker if we need to update scopes again in the future but keeping the old one makes more sense to me still as we can always ask Support to update accordingly and it won't log out existing users.

I suppose it's your call @marks as the author. We can wait and I'll email them again otherwise yeah we can proceed with this PR.

xmok avatar Nov 04 '24 15:11 xmok

Hey @xmok - I agree having Airtable fix is the purest solution, but it sounds like you're unfortunately not getting good responsiveness from them (sorry).

Since #14864 is already merged and people are running into this issue, I guess it makes sense for you to change the client ID.

@pernielsentikaer - do you all usually expect individuals to own default client IDs like this?

marks avatar Nov 04 '24 16:11 marks

No I don't think we do that often, let's merge and see how it goes 🙂

pernielsentikaer avatar Nov 05 '24 10:11 pernielsentikaer

Published to the Raycast Store: https://raycast.com/marks/raycast-airtable-extension

github-actions[bot] avatar Nov 05 '24 12:11 github-actions[bot]

:tada: :tada: :tada:

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

raycastbot avatar Nov 05 '24 12:11 raycastbot