extensions icon indicating copy to clipboard operation
extensions copied to clipboard

[Zen Browser] Bookmarks / Profile Selection Issue

Open theherk opened this issue 1 year ago • 3 comments

Extension

https://www.raycast.com/Keyruu/zen-browser

Raycast Version

1.84.3

macOS Version

15.0.1

Description

The only bookmarks shown to me in "Search Bookmarks" are the 5 default bookmarks. I'm not sure where they're coming from. I have one profile, and one profile directory. It has these default bookmarks deleted and several others created. The history in "Search History" and "New Tab" are correct, though.

Screenshot 2024-10-28 at 11 34 24

Screenshot 2024-10-28 at 11 29 28

Screenshot 2024-10-28 at 11 30 45

Steps To Reproduce

I'm really not sure how to reproduce this one, but I've provided as much information as I have.

Current Behaviour

I get the default bookmarks from a profile that doesn't exist. Maybe a cache thing.

Expected Behaviour

I can search my bookmarks.

theherk avatar Oct 28 '24 10:10 theherk

Thank you for opening this issue!

🔔 @Keyruu @crisboarna @grandkrav @Laptop765 you might want to have a look.

💡 Author and Contributors commands

The author and contributors of Keyruu/zen-browser can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot close as not planned Closes the issue as not planned.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopens the issue.
  • @raycastbot assign me Assigns yourself to the issue.
  • @raycastbot good first issue Adds the "Good first issue" label to the issue.
  • @raycastbot keep this issue open Make sure the issue won't go stale and will be kept open by the bot.

raycastbot avatar Oct 28 '24 10:10 raycastbot

Oh sorry for the ping to the firefox extension maintainers. How can I remove you from that?

Keyruu avatar Oct 28 '24 16:10 Keyruu

But about the issue: I'll have to check this, maybe it only shows me the bookmarks it synced from Firefox and not the new ones I added in Zen.

Keyruu avatar Oct 28 '24 16:10 Keyruu

At some point, with no changes from me, it added the proper bookmarks. However, it still has the default bookmarks even though they're removed, and doesn't keep up-to-date. Since there is no cache for the plugin, I don't know how it is updated or even can get out-of-sync, but it does seem to lag behind actual updates to bookmarks. For instance, I've added a new bookmark and it doesn't show. Maybe in some days, it will.

theherk avatar Nov 04 '24 15:11 theherk

Wait, just looking through the source code, it looks like this reads bookmarks from /bookmarkbackups rather than from the sqlite db, so they will only ever be up-to-date with the backup file. Maybe that should change?

In any case the workaround is to take a backup, which no matter where you set it, will also create a backup in the profile directory and update the plugins results. I'll leave it to you if this behavior should change.

theherk avatar Nov 04 '24 16:11 theherk

Yup, this is how the current Firefox extension handles it, I have no idea why. Will create a PR with a fix that should display all bookmarks and be up to date with the ones in the browser :D

Keyruu avatar Nov 08 '24 15:11 Keyruu