extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Update ilovepdf extension

Open ridemountainpig opened this issue 1 year ago • 2 comments

Description

Add a feature to select files from Finder closes #15061

Screencast

CleanShot 2024-10-26 at 11 46 29@2x

Checklist

ridemountainpig avatar Oct 26 '24 03:10 ridemountainpig

Thank you for your contribution! :tada:

🔔 @MohamedK1 you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

raycastbot avatar Oct 26 '24 03:10 raycastbot

@MohamedK1 do you want to check this?

@pernielsentikaer will have a look this week. Thanks for letting me know

MohamedK1 avatar Oct 31 '24 09:10 MohamedK1

Could you look into this @ridemountainpig

pernielsentikaer avatar Nov 04 '24 22:11 pernielsentikaer

Could you look into this @ridemountainpig

I will update it in the next few days. Thank you.

ridemountainpig avatar Nov 05 '24 00:11 ridemountainpig

@MohamedK1 I have updated the code based on your review. Please check it. Thank you.

ridemountainpig avatar Nov 05 '24 15:11 ridemountainpig

@MohamedK1 do you have more feedback here?

pernielsentikaer avatar Nov 12 '24 05:11 pernielsentikaer

@MohamedK1 pinging one last time 🙂

pernielsentikaer avatar Nov 17 '24 06:11 pernielsentikaer

@MohamedK1 do you have more feedback here?

@pernielsentikaer, @ridemountainpig Sorry for delayed response, I had a couple of very busy weeks. Will check the PR and comment accordingly if there are any other things

MohamedK1 avatar Nov 17 '24 21:11 MohamedK1

Thanks for checking @MohamedK1 🙏 Sorry for the ping 🙂

pernielsentikaer avatar Nov 18 '24 07:11 pernielsentikaer

Is this ready for another review?

pernielsentikaer avatar Nov 20 '24 20:11 pernielsentikaer

Is this ready for another review?

Yes, thank you, @pernielsentikaer and @MohamedK1.

ridemountainpig avatar Nov 21 '24 00:11 ridemountainpig

Published to the Raycast Store: https://raycast.com/mohamedk1/ilovepdf

github-actions[bot] avatar Nov 21 '24 12:11 github-actions[bot]

:tada: :tada: :tada:

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

raycastbot avatar Nov 21 '24 12:11 raycastbot