extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Add multi-links extension

Open wrick17 opened this issue 1 year ago β€’ 4 comments

Description

Screencast

Checklist

wrick17 avatar Oct 25 '24 12:10 wrick17

Congratulations on your new Raycast extension! :rocket:

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

raycastbot avatar Oct 25 '24 12:10 raycastbot

Hi πŸ‘‹

Thanks for your contribution πŸ’ͺ

I have now tested your extension, and I have some feedback ready for you:

I'm looking forward to testing this extension again πŸ”₯

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

Hi @pernielsentikaer that's a great suggestion. I couldn't find a proper way to open the default browser so I used this code I found somewhere on the internet. It does open my default browser, however I've not tested it extensively. If you tell me what's the correct way to open it in the default browser, I'll gladly put that in.

wrick17 avatar Oct 31 '24 10:10 wrick17

await open(url); should be more than enough πŸ™‚

pernielsentikaer avatar Oct 31 '24 10:10 pernielsentikaer

await open(url); should be more than enough πŸ™‚

Ah! That simple huh? πŸ˜…

wrick17 avatar Oct 31 '24 10:10 wrick17

await open(url); should be more than enough πŸ™‚

@pernielsentikaer Done!

wrick17 avatar Nov 02 '24 08:11 wrick17

I tried to get it to work, if I debug selectedText and urls which gives me

23:04:53.286 πŸš€ ~ main ~ selectedText: Hello www.raycat.com is really good www.dr.dk
23:04:53.286 πŸš€ ~ main ~ urls: undefined

Shouldn't it give some urls?

pernielsentikaer avatar Nov 04 '24 22:11 pernielsentikaer

It particularly looks for http or https to make sure that they are links and not things like package names and such.

On Tue, Nov 5, 2024 at 03:36 Per Nielsen Tikær @.***> wrote:

I tried to get it to work, if I debug selectedText and urls which gives me

23:04:53.286 πŸš€ ~ main ~ selectedText: Hello www.raycat.com is really good www.dr.dk 23:04:53.286 πŸš€ ~ main ~ urls: undefined

Shouldn't it give some urls?

β€” Reply to this email directly, view it on GitHub https://github.com/raycast/extensions/pull/15082#issuecomment-2455796653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB67D3BXAIDRVKX2ULQX34LZ67VWFAVCNFSM6AAAAABQTFW22GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVG44TMNRVGM . You are receiving this because you authored the thread.Message ID: @.***>

wrick17 avatar Nov 05 '24 01:11 wrick17

Published to the Raycast Store: https://raycast.com/wrick17/multi-links

github-actions[bot] avatar Nov 05 '24 14:11 github-actions[bot]

:tada: :tada: :tada:

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@wrick17). Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

raycastbot avatar Nov 05 '24 14:11 raycastbot

Hi πŸ‘‹

Looks good to me, approved πŸ”₯

Awesome. Thanks. I've also linked my Github account.

wrick17 avatar Nov 05 '24 14:11 wrick17