extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Add time-machine extension

Open SuoweiHu opened this issue 1 year ago • 1 comments

Description

This extension helps the TimeMachine user to start, stop backup, and reveal/browse historical backup on different destination. Hope you will like it 👍

Screencast / Video

https://github.com/raycast/extensions/assets/35317549/ee0a5681-e722-41ae-9694-49a365bc13e4

2024-07-10T113200

2024-07-10T113220

2024-07-10T113228

Checklist

SuoweiHu avatar Jul 10 '24 01:07 SuoweiHu

Congratulations on your new Raycast extension! :rocket:

We're currently experiencing high demand and limited capacity. As a result, extension reviews might take longer than usual to get the initial review. Please expect an initial review within 5-10 business days.

Once the PR is approved and merged, the extension will be available on our Store.

Sorry for the inconvenience

raycastbot avatar Jul 10 '24 01:07 raycastbot

Hey! Is your extension ready for review? I saw you added a few more commits after the initial push.

mil3na avatar Jul 11 '24 13:07 mil3na

Hello @mil3na, thank you for your detailed attention! Yes, it is ready to review (just spotted a few issue yesterday and quickly patching them with those commits)

SuoweiHu avatar Jul 11 '24 22:07 SuoweiHu

Hello Milena,

Thank you for spotting those issues !

Lemme fix those and get back to you (・ω・)b

SuoweiHu avatar Jul 14 '24 07:07 SuoweiHu

Hello @mil3na, I've got the nominated issue/problems patched:

  • [x] Fix indentation of package.json via prettier
  • [x] Remove un-used action for cmd-list-destination.tsx
  • [x] Fixing typo of error message when start-backup fails
  • [x] Fix []:[] error, via show <List.EmptyView> when no backup can be found on the destination (see demo video: link)

Please let me know if there's anything else you feel like need extra work !

SuoweiHu avatar Jul 14 '24 23:07 SuoweiHu

Hi! Thanks for updating your PR. However, I still get that same error page when using the List Backup command. I never did a Time Machine backup in this machine, if that helps debugging.

mil3na avatar Jul 16 '24 08:07 mil3na

Hi! Thanks for updating your PR. However, I still get that same error page when using the List Backup command. I never did a Time Machine backup in this machine, if that helps debugging.

Ah sorry about that, with your provided detail I think I can guess where the issue is, lemme try patching that again and get back to you, won't be long.

SuoweiHu avatar Jul 16 '24 22:07 SuoweiHu

Hi! Thanks for updating your PR. However, I still get that same error page when using the List Backup command. I never did a Time Machine backup in this machine, if that helps debugging.

Ah sorry about that, with your provided detail I think I can guess where the issue is, lemme try patching that again and get back to you, won't be long.

I think i've got it fixed now (see video: link), may I bother you to take another look ? 😊

SuoweiHu avatar Jul 16 '24 22:07 SuoweiHu

Published to the Raycast Store: https://raycast.com/SuoweiHu/time-machine

github-actions[bot] avatar Jul 17 '24 08:07 github-actions[bot]

:tada: :tada: :tada:

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

raycastbot avatar Jul 17 '24 08:07 raycastbot

LGTM!

In the future, maybe improve the error messages and do not allow start/stop backups if there's no backup disk :)

Most definitely. Thanks a ton for bearing with my long conversation for bugs ! Appreciated your time and have a nice day !

SuoweiHu avatar Jul 17 '24 22:07 SuoweiHu