extensions icon indicating copy to clipboard operation
extensions copied to clipboard

[Keyboard brightness] Improve user feedback and error handling

Open DannySeidel opened this issue 1 year ago • 1 comments

Description

  • Remove adjust-brightness command as it is replaced by increase-brightness and decrease-brightness commands
  • Improve user feedback and error handling by showing the new brightness value when adjusted
  • Force displayed brightness to be whole percentage values

Screencast

keyboard-brightness-1

Checklist

DannySeidel avatar Apr 10 '24 19:04 DannySeidel

Thank you for your contribution! :tada:

🔔 @neo773 @belyakov-am you might want to have a look.

raycastbot avatar Apr 10 '24 19:04 raycastbot

LGTM! cc @pernielsentikaer

neo773 avatar Apr 12 '24 08:04 neo773

@DannySeidel On second thoughts could you change the screenshot to this? Raycast 2024-04-12 at 13 48 54

neo773 avatar Apr 12 '24 08:04 neo773

There is actually no reason to add a screenshot anymore since it's only no-view commands. You can still have an image in the README if you'd like.

This is taken from the manual:

Select the most informative commands to showcase what your extension does – focus on giving the user as much detail as possible

pernielsentikaer avatar Apr 12 '24 08:04 pernielsentikaer

Hey @neo773,

sure I change it if you want. Or do you prefer to not have a screenshot as @pernielsentikaer suggested?

DannySeidel avatar Apr 12 '24 08:04 DannySeidel

@DannySeidel Let's keep it, store preview looks weird with no screenshot in my opinion.

neo773 avatar Apr 12 '24 08:04 neo773

I agree no screenshot looks weird 👍🏻 I updated the screenshot

DannySeidel avatar Apr 12 '24 08:04 DannySeidel

@DannySeidel Thank you for your contribution I appreciate it!

Can we get this merged now? @pernielsentikaer

neo773 avatar Apr 12 '24 08:04 neo773

@DannySeidel do you want to have your Raycast handle added to the package.json?

pernielsentikaer avatar Apr 12 '24 08:04 pernielsentikaer

Sorry forgot that, I will add it

DannySeidel avatar Apr 12 '24 09:04 DannySeidel

Done! @pernielsentikaer thanks for reminding me 🙏🏻

DannySeidel avatar Apr 12 '24 09:04 DannySeidel

I have also ensured that the menu bar always displays the correct tooltip after using the commands 🙂

pernielsentikaer avatar Apr 12 '24 09:04 pernielsentikaer

Published to the Raycast Store: https://raycast.com/huzef44/keyboard-brightness

github-actions[bot] avatar Apr 12 '24 09:04 github-actions[bot]

:tada: :tada: :tada:

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

raycastbot avatar Apr 12 '24 09:04 raycastbot