navigator.lua icon indicating copy to clipboard operation
navigator.lua copied to clipboard

Published 20 hours ago • verified publisher icon ray-x

take into account luadev config

Open blob42 opened this issue 3 years ago • 7 comments

Hi, sorry my last fix was still not working I had to dig deeper and found that the luadev generated config was never included/merged.

blob42 avatar Sep 12 '22 11:09 blob42

Did you push your changes?

ray-x avatar Sep 12 '22 12:09 ray-x

Yes this PR should be good

blob42 avatar Sep 12 '22 14:09 blob42

Strange, as it shows there are no files changed for the PR. image

ray-x avatar Sep 13 '22 01:09 ray-x

Yes strange, the change was here https://github.com/ray-x/navigator.lua/pull/230/commits/c84b2964f9646b9c935af01ba1f02f1c30b7d457

Side note, this has enabled navigator to setup luadev and take into account the extra workspaces I define but I still cannot get the help signature for vim internal apis to work. I don't know if I am missing something or just a problem from luadev with nightly neovim.

blob42 avatar Sep 13 '22 07:09 blob42

Is it because that commit was already merged?

ray-x avatar Sep 13 '22 09:09 ray-x

I just pushed an extra commit on my github branch and then used the GH button to pull the changes and make a PR, I didn't do any manual merge locally

blob42 avatar Sep 13 '22 10:09 blob42

I think it is duplicated as this PR: https://github.com/ray-x/navigator.lua/pull/229/files So GitHub shows there were no changes

ray-x avatar Sep 13 '22 11:09 ray-x

Yes it is I will close this one then.

blob42 avatar Sep 20 '22 13:09 blob42