navigator.lua icon indicating copy to clipboard operation
navigator.lua copied to clipboard

Known issues, new features and breaking changes

Open ray-x opened this issue 4 years ago • 10 comments

Issue:

(Fixed) (1) Open preview when split windows present may close the split window. It might be caused by an incorrect window id.

(Fixed) (2) Breaking changes: https://github.com/neovim/neovim/pull/13664. (Fixed)

(merged) (3) gopls report error 'file://' not found in workspace. This is caused gopls is thinking floating windows with syntax on is a 'go' file. Fix is under testing. PR : https://github.com/neovim/nvim-lspconfig/pull/944.

(merged) (4) Breaking changes neovim floating_windows. neovim changed its' API https://github.com/neovim/neovim/pull/14649 it has some side effects include the position of "apply action" floating window. Will working on them. (May 25)

Improvements

1) Backspace in search prompt 2) Fully configurable 3) PHP, dockerls support

PR welcome

ray-x avatar Apr 25 '21 03:04 ray-x

Hi, is this list still up-to-date? I.e., this plugin should not work with nvim 0.5? I just installed it and I get a lot of errors such as windows missing where I expect one or lua errors. Should I file a bug report, or is this expected with nvim 0.5?

Regards, Robert

RobertBuhren avatar Jul 17 '21 21:07 RobertBuhren

Hi, The list was not up-to-date.

Thanks for trying the plugin and report issue. Could you share your config?

My minium config:

set termguicolors
call plug#begin('~/.vim/plugged')
Plug 'neovim/nvim-lspconfig'
Plug 'nvim-treesitter/nvim-treesitter'

Plug 'ray-x/guihua.lua'
Plug 'ray-x/navigator.lua'

call plug#end()

lua <<EOF
local single = {"╭", "─", "╮", "│", "╯", "─", "╰", "│"}
require"navigator".setup({
  debug = true,
  width = 0.7,
  border = single, -- "single"
})
EOF
set mouse=a
                                                                                                                                                                      

I am tracking neovim upstream. But I can not verify every operating system and setup.

ray-x avatar Jul 18 '21 03:07 ray-x

Hi, I wanted to ask if [d and ]d both going to the next diagnostic is a known issue. Also gopls code actions don't seem to be working if I use jk keys in the float window. Not sure if this is the correct place to ask.

behzade avatar Aug 25 '21 12:08 behzade

Please submit a separate issue. I can not reproduce this issue. It would be great to attach your config and your operation system. [d should work out of box and it calls neovim lsp API directly. The plugin only provides keymappings. I suspect the gopls was not loaded correctly

ray-x avatar Aug 25 '21 15:08 ray-x

Your fix should work. Thanks!

ray-x avatar Aug 25 '21 23:08 ray-x

You may want to update the documentation to note that folke/lua-dev.nvim is now a strictly enforced mandatory dependency, because opening even just an empty non lua buffer results in:

Error: attempted to load lua-dev.nvim which is not present in plugins table!                                                                                                                                    
Error in packer_compiled: ...vim/site/pack/packer/opt/packer.nvim/lua/packer/load.lua:13: Error: attempted to load lua-dev.nvim which is not present in plugins table!                                          
Please check your config for correctness                                                                                                                                                                        
Press ENTER or type command to continue 

If you don't have lua-dev installed

Corey-Keller avatar Oct 04 '21 18:10 Corey-Keller

This behaviour is incorrect. Should be fixed in https://github.com/ray-x/navigator.lua/commit/faab21a1a78bd62d9063b9589b76b05938785e47

ray-x avatar Oct 04 '21 22:10 ray-x

image

Moving to new neovim API for key binding

The new way to bind a key is { key = 'gr', func = require('navigator.reference').async_ref, desc = 'async_ref' },

doc field is optional Also as vim.keymap.set() only supported 0.7.x and greater so 0.6.x might no longer works.

ray-x avatar Jul 02 '22 01:07 ray-x

Notes.

{ key = 'gr', func = require('navigator.reference').async_ref, ~~doc~~ = 'async_ref' }

is moving to

{ key = 'gr', func = require('navigator.reference').async_ref, **desc** = 'async_ref' },

Also

{ key = "<Leader>re", func = "rename()" }, 

must move to

{ key = "<Leader>re", func = vim.lsp.buf.rename }, 

You can not shorten it to rename()

There was some doc was not updated.

ray-x avatar Jul 12 '22 01:07 ray-x

breaking: I created a new branch neodev to reflect recent change from lua-dev. In long term. I may remove neodev support from the plugin as it is not necessary with latest updates from neodev.

ray-x avatar Oct 19 '22 03:10 ray-x