go.nvim icon indicating copy to clipboard operation
go.nvim copied to clipboard

`run_in_floaterm` overrides test_runner is using go

Open MadsRC opened this issue 2 years ago • 2 comments

I recently tried setting run_in_floaterm and noticed that the next time I ran :GoTest, richgo test -v ... would be executed instead of the regular go test runner I have configured.

I then tried to reconfigure test_runner to use richgo instead, and that caused richgo test ... to be run when I ran :GoTest (notice the missing -v despite also having verbose_tests set to true (I know it's deprecated).

I had a look at the codebase, but couldn't immediately locate the culprit - Lua isn't my strong side.

This was replicated using the default config from the README.md file.

MadsRC avatar May 19 '23 20:05 MadsRC

Yes, richgo will overrides default test_runner if running in floating term... This is because it looks better in floating terminal. Do you want me adding -v to the richgo test ?

ray-x avatar May 22 '23 10:05 ray-x

I found this issue after experiencing the same behavior. Personally I would expect it to honor test_runner regardless of using run_in_floaterm or not, specifically because that is the output I prefer to see.

shaunduncan avatar Apr 27 '24 12:04 shaunduncan

I think the issue is obsolete, as richgo has been removed. other test_runner will not be override run_in_floaterm setting.

ray-x avatar May 22 '24 22:05 ray-x