Change PhysicalOperator.completed() to has_completed() and update all…

Open simeetnayan81 opened this issue 1 month ago • 1 comments

Description

This is a follow-up PR after: #58915 for changing the function name from completed() to has_completed() in the class PhycicalOperator. This is in-line with our discussions with @bveeramani here: https://github.com/ray-project/ray/pull/58915#pullrequestreview-3497529812. This is done to make it clear that the method doesn't modify state and has no side effects.

Related issues

#58884

Additional information

Just updated the completed() and all it's references in other classes and tests.

Dec 07 '25 05:12 simeetnayan81

@simeetnayan81 Thanks for your contributions. Can you please fix the build failures?

Dec 11 '25 00:12 gvspraveen

@gvspraveen @bveeramani Hey, I've fixed the issues causing tests to fail. Kindly review once and merge.

Dec 12 '25 08:12 simeetnayan81

LGTM! Thank you for the contribution!

Dec 12 '25 09:12 bveeramani