ray icon indicating copy to clipboard operation
ray copied to clipboard

[serve] add result(...) to DeploymentResponseGenerator to fix static typing

Open SolitaryThinker opened this issue 1 month ago • 3 comments

Description

This PR adds a dummy .result() API to DeploymentResponseGenerator`.

DeploymentResponseGenerator currently doesn't support .result(), however when calling .remote() on a DeploymentHandle, the return type is a Union of DeploymentResponseGenerator and DeploymentResponse. Meaning if .result() is on the object, a typing error is raised.

Example error without this PR: image

Related issues

fixes https://github.com/ray-project/ray/issues/52493

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

SolitaryThinker avatar Nov 11 '25 01:11 SolitaryThinker

This pull request has been automatically marked as stale because it has not had any activity for 14 days. It will be closed in another 14 days if no further activity occurs. Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

github-actions[bot] avatar Dec 06 '25 12:12 github-actions[bot]

please fix the premerge

abrarsheikh avatar Dec 08 '25 18:12 abrarsheikh

looking into docs error

SolitaryThinker avatar Dec 08 '25 23:12 SolitaryThinker