ray icon indicating copy to clipboard operation
ray copied to clipboard

[Core] Ensure Ray vendored libraries only be visible and used by Ray internal

Open Bye-legumes opened this issue 8 months ago • 3 comments

Why are these changes needed?

fix issue https://github.com/ray-project/ray/issues/52763

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

Bye-legumes avatar May 09 '25 18:05 Bye-legumes

Thanks for working on this one!

jjyao avatar May 12 '25 16:05 jjyao

I asked chatgpt, seems changing sys.modules is considered a discouraged way of vendoring. Instead, we should check in the source code directly (see. ray/_private/thirdparty). I'm having a PR for setproctitle (#53471). Could you open a PR for colorama to check in it's source code to ray/_private/thirdparty. It should be straightforward since it's a python only library.

jjyao avatar Jun 02 '25 20:06 jjyao

This pull request has been automatically marked as stale because it has not had any activity for 14 days. It will be closed in another 14 days if no further activity occurs. Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

github-actions[bot] avatar Jun 17 '25 00:06 github-actions[bot]

This pull request has been automatically closed because there has been no more activity in the 14 days since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

github-actions[bot] avatar Jul 01 '25 12:07 github-actions[bot]