AMD new products 2025 q2
Why are these changes needed?
Adding new GPU products for MI3xx product line
Checks
- [x] I've signed off every commit(by using the -s flag, i.e.,
git commit -s) in this PR. - [x] I've run
scripts/format.shto lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I added a
method in Tune, I've added it in
doc/source/tune/api/under the corresponding.rstfile.
- [ ] I've added any new APIs to the API Reference. For example, if I added a
method in Tune, I've added it in
- [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
- [x] Unit tests
- [ ] Release tests
- [ ] This PR is not tested :(
Unit test results
root@hpe-hq-08:/app/ray# python -m pytest -v -s python/ray/tests/accelerators/test_amd_gpu.py ============================================================= test session starts ============================================================= platform linux -- Python 3.12.9, pytest-7.3.2, pluggy-1.5.0 -- /opt/conda/envs/py_3.12/bin/python cachedir: .pytest_cache hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/app/ray/.hypothesis/examples') rootdir: /app/ray configfile: pytest.ini plugins: hypothesis-5.35.1, rerunfailures-14.0, flakefinder-1.1.0, xdist-3.3.1, cpp-2.3.0, xdoctest-1.1.0, typeguard-4.3.0 collected 5 items
python/ray/tests/accelerators/test_amd_gpu.py::test_visible_amd_gpu_ids Usage stats collection is enabled by default for nightly wheels. To disable this, run the following command: ray disable-usage-stats before starting Ray. See https://docs.ray.io/en/master/cluster/usage-stats.html for more details.
2025-03-28 23:04:46,902 INFO worker.py:1852 -- Started a local Ray instance.
PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_visible_amd_gpu_type Usage stats collection is enabled by default for nightly wheels. To disable this, run the following command: ray disable-usage-stats before starting Ray. See https://docs.ray.io/en/master/cluster/usage-stats.html for more details.
2025-03-28 23:04:52,082 INFO worker.py:1852 -- Started a local Ray instance.
PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_visible_amd_gpu_type_bad_device_id Usage stats collection is enabled by default for nightly wheels. To disable this, run the following command: ray disable-usage-stats before starting Ray. See https://docs.ray.io/en/master/cluster/usage-stats.html for more details.
2025-03-28 23:04:57,418 INFO worker.py:1852 -- Started a local Ray instance.
PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_get_current_process_visible_accelerator_ids PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_set_current_process_visible_accelerator_ids PASSED
============================================================= 5 passed in 15.70s ==============================================================
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
- If you'd like to keep this open, just leave any comment, and the stale label will be removed.
@jjyao Would you please help review this PR.
This pull request has been automatically marked as stale because it has not had any activity for 14 days. It will be closed in another 14 days if no further activity occurs. Thank you for your contributions.
You can always ask for help on our discussion forum or Ray's public slack channel.
If you'd like to keep this open, just leave any comment, and the stale label will be removed.
@vickytsang do we still want to merge this PR? Sorry for missing it.
@vickytsang could you rebase if you still want to merge this PR