ray icon indicating copy to clipboard operation
ray copied to clipboard

[style] flake8 violation E501 fix

Open JP-sDEV opened this issue 1 year ago • 2 comments

Why are these changes needed?

Fixes flake8 linting error E501, line too long (82 > 79 characters).

Ran the flake8 linting script

flake8 --select E501 --extend-exclude python/ray/core/generated,python/ray/serve/generated/,python/ray/cloudpickle/,python/ray/_private/runtime_env/_clonevirtualenv.py,doc/external/,python/ray/dashboard/client/node_modules,python/.venv

Note: python/.venv was ignored added to the original script since I created a virtualenv to run the flake8 script.

Related issue number

Closes #48061

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

cc: @MortalHappiness

JP-sDEV avatar Oct 18 '24 18:10 JP-sDEV

Hi @JP-sDEV, thank you for your contribution! However, you forgot to sign off on your latest commit, and the lint CI failed. Please note that the pre-commit hook still needs to be run, as I mentioned in the parent issue. Make sure the flake8 command passes before you create a commit.

MortalHappiness avatar Oct 19 '24 11:10 MortalHappiness

Sure, I will make sure the flake8 command passes as well as the lint workflow passes in my forked repo passes before resubmitting. Will start working on it on Monday!

JP-sDEV avatar Oct 20 '24 01:10 JP-sDEV

Thank you @MortalHappiness, the suggested changes have been applied. Cheers! :)

JP-sDEV avatar Oct 22 '24 15:10 JP-sDEV

@MortalHappiness done! Thank you for your patience and for guiding me through this :)

JP-sDEV avatar Oct 23 '24 13:10 JP-sDEV

@JP-sDEV Could you rebase with the master branch to trigger the CI to see if the failed tests can pass? Thanks

MortalHappiness avatar Oct 29 '24 12:10 MortalHappiness

Hey @JP-sDEV @MortalHappiness what's the status of this one?

jcotant1 avatar Nov 13 '24 17:11 jcotant1

@jcotant1 I am waiting for @JP-sDEV to sync with the master branch.

MortalHappiness avatar Nov 13 '24 22:11 MortalHappiness

@MortalHappiness @jcotant1 working on it now, should be pushed in a couple hours. Apologies for the delay

JP-sDEV avatar Nov 14 '24 13:11 JP-sDEV

@JP-sDEV seems the PR has some rebase issue. It now contains lots of unrelated changes.

jjyao avatar Nov 14 '24 17:11 jjyao

Close this because we decide to migrate from flake8 to ruff instead of upgrading flake8.

MortalHappiness avatar Jan 13 '25 06:01 MortalHappiness