ray icon indicating copy to clipboard operation
ray copied to clipboard

Split python/ray/tests/test_actor_retry over two files

Open mattip opened this issue 1 year ago • 5 comments

Why are these changes needed?

The test_actor_retry tests are failing/flaky on windows. They pass locally. I have not been able to access the CI logs to see what is going wrong. In order to shrink the problem (is it a overall timeout? Is one of the tests failing?) we can start by splitting the tests into two files.

Related issue number

Toward solving #43845.

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

mattip avatar Aug 18 '24 08:08 mattip

cc @anyscalesam

mattip avatar Aug 18 '24 09:08 mattip

There are two overall strategies: TroubleMaker and AsyncTroubleMaker. I moved the (simpler) TroubleMaker-only tests to the new file, and left the ones that use the AsyncTroubleMaker

mattip avatar Aug 19 '24 19:08 mattip

@anyscalesam @aslonnie any more questions?

mattip avatar Aug 27 '24 05:08 mattip

asking @rynewang @jjyao for opinions.

aslonnie avatar Aug 27 '24 07:08 aslonnie

I'm ok with this.

rynewang avatar Aug 28 '24 19:08 rynewang

Auto-merge did not trigger. Do I need to rebase the PR?

mattip avatar Aug 29 '24 14:08 mattip