ray icon indicating copy to clipboard operation
ray copied to clipboard

[util] remove pygloo support

Open aslonnie opened this issue 1 year ago • 20 comments

pygloo support stops at python 3.8, which ray does not support. the pygloo package is effectively already dead

aslonnie avatar Jul 12 '24 05:07 aslonnie

(jiajun the great can review everything..)

aslonnie avatar Jul 12 '24 05:07 aslonnie

@jovany-wang is https://github.com/ray-project/pygloo still maintained? I saw you had a commit 2 months ago. If it's still maintained, it needs to support newer version of python.

jjyao avatar Jul 12 '24 05:07 jjyao

@jjyao Yes. We are still maintaining it. Do we still need it in Ray in some scenarios?

jovany-wang avatar Jul 12 '24 05:07 jovany-wang

@jovany-wang can you then make it support python versions 3.9+. The old versions are EOLed.

jjyao avatar Jul 12 '24 05:07 jjyao

@jjyao Sure. I'll tell you our plan later.

jovany-wang avatar Jul 12 '24 06:07 jovany-wang

FYI @Catch-Bull @larrylian

jovany-wang avatar Jul 12 '24 06:07 jovany-wang

For what it's worth, I have some use cases for the collective communication on CPU via pygloo, so I hope it doesn't get removed. I managed to get pygloo to build for Python 3.11 by just updating pybind11_bazel and pybind11 in the WORKSPACE file and updating setup.py. It appears to work fine.

This seems like a few hours of work for someone more familiar with Bazel than I am, so I certainly hope that we don't just delete!

terraflops1048576 avatar Jul 12 '24 15:07 terraflops1048576

@terraflops1048576 Thanks for your feedback.

jovany-wang avatar Jul 12 '24 15:07 jovany-wang

Let me clarify that if it's worth to have, then we need make it work.

jovany-wang avatar Jul 12 '24 15:07 jovany-wang

Let me clarify that if it's worth to have, then we need make it work.

do we have a timeline?

new wheels (py39 310 311 312) need to be published on pypi.

aslonnie avatar Jul 12 '24 16:07 aslonnie

ping, any follow up?

aslonnie avatar Jul 18 '24 03:07 aslonnie

fwiw, there is no intersection on python version between ray release and gloo. when gloo starts catching up, we can always revert this change and add gloo back.

aslonnie avatar Jul 18 '24 03:07 aslonnie

Would sample wheels for Python 3.11 or a hacked together pygloo repository be helpful for updating?

terraflops1048576 avatar Jul 21 '24 16:07 terraflops1048576

Would sample wheels for Python 3.11 or a hacked together pygloo repository be helpful for updating?

how would a ray user use it? why only 3.11?

aslonnie avatar Jul 30 '24 15:07 aslonnie

As in it's a pretty easy task to build for Python 3.11 (which is the Python that I regularly use for projects). It was a matter of changing the dependencies in the pygloo repository. The code almost all works fine with only minor tweaks. However, it looks like the maintainer hasn't gotten to it.

I can probably build these wheels for all Python versions >= 3.9, but probably not for all platforms.

terraflops1048576 avatar Aug 03 '24 06:08 terraflops1048576

any update?

aslonnie avatar Sep 10 '24 03:09 aslonnie

Hi, thanks. I will reply to you soon when I'm back.

larrylian avatar Sep 10 '24 03:09 larrylian

Hi, thanks. I will reply to you soon when I'm back.

any update?

aslonnie avatar Oct 18 '24 22:10 aslonnie

Hi, thanks. I will reply to you soon when I'm back.

larrylian avatar Oct 18 '24 22:10 larrylian

Hi, thanks. I will reply to you soon when I'm back.

and when is that? like is it okay to commit this change and revert this change when you are back and have progress?

the python version that ray supports now has no intersection with pygloo. this code is effectively dead weight in the code base, and we have been waiting for 3 months.

aslonnie avatar Oct 18 '24 22:10 aslonnie

@aslonnie My apologies for not noticing earlier. I will address this issue within a week and will keep you updated on the progress. I'll try to update pygloo to support python 3.10、3.11...

larrylian avatar Oct 25 '24 05:10 larrylian

@aslonnie I have urgently upgraded the version of PyGloo and it now supports Python versions 3.8, 3.9, and 3.10. In a few days, @jovany-wang will help upload it to the pip repository, and then you will be able to use it normally.

larrylian avatar Nov 01 '24 06:11 larrylian

@aslonnie I have urgently upgraded the version of PyGloo and it now supports Python versions 3.8, 3.9, and 3.10. In a few days, @jovany-wang will help upload it to the pip repository, and then you will be able to use it normally.

thanks. is it released on pypi? or where should user find the release to install?

aslonnie avatar Nov 01 '24 16:11 aslonnie

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Feb 25 '25 00:02 stale[bot]

@aslonnie pygloo 0.2.1 was released.

jovany-wang avatar Feb 28 '25 08:02 jovany-wang