ray icon indicating copy to clipboard operation
ray copied to clipboard

[Dashboard] Upgrade to MUIv5 and dependency updates

Open liuxsh9 opened this issue 1 year ago • 4 comments

Why are these changes needed?

This PR replaces the current makeStyles in the Dashboard with the MUIv5 recommended styled approach, thereby removing the @mui/styles transitional package, which facilitates future upgrades and expansions. Additionally, the React framework has been upgraded to version 18.3.0, and lowlight has been upgraded to version 2.9.0.

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

liuxsh9 avatar Jun 07 '24 01:06 liuxsh9

@aslonnie @alanwguo can PTAL and see if this is safe to merge; nice to have an upgrade in... and if our CI and release test pass I don't think there is any harm in keeping up to date.

anyscalesam avatar Jun 14 '24 21:06 anyscalesam

I really have no opinion / saying on this.. this is like pure js land stuff, will leave this to @alanwguo and dashboard / observability team

if we need to upgrade npm or something to make this happen, let me know.

aslonnie avatar Jun 16 '24 03:06 aslonnie

side note: this PR looks rather big, might be easier to get it merge if this can be done in stages, though I do not really know technically how to make it happen.

aslonnie avatar Jun 16 '24 03:06 aslonnie

Thanks for the suggestions! We've completed the corresponding modifications. How does the new version look? @alanwguo

liuxsh9 avatar Jun 26 '24 07:06 liuxsh9