ray icon indicating copy to clipboard operation
ray copied to clipboard

[RLlib] PyFlyt QuadX WayPoints

Open peterghaddad opened this issue 2 months ago • 7 comments

Why are these changes needed?

An example to leverage the PyFlyt environment with RLlib enabling users to train drones in the PyBullet physics engine.

Related issue number

Closes #44738

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [x] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [x] Release tests
    • [ ] This PR is not tested :(

peterghaddad avatar Apr 16 '24 02:04 peterghaddad

@sven1977 @simonsays1980 can you take a look please?

anyscalesam avatar Apr 30 '24 21:04 anyscalesam

@simonsays1980 addressed feedback! Let me know if there is anymore feedback!

peterghaddad avatar May 14 '24 21:05 peterghaddad

@simonsays1980 addressed feedback! Let me know if there is anymore feedback!

@peterghaddad Thanks for the comments! So, for the error occuring in the new stack we need to dig into this deeper. I have a guess, where this is rooted. I come back to you when I know more.

simonsays1980 avatar May 15 '24 09:05 simonsays1980

@simonsays1980 addressed feedback! Let me know if there is anymore feedback!

@peterghaddad Thanks for the comments! So, for the error occuring in the new stack we need to dig into this deeper. I have a guess, where this is rooted. I come back to you when I know more.

@simonsays1980 Appreciate you diving in! From a quality and training perspective, I think this example is good to go. LSTM isn't necessary for us to move forward; however, i'm glad we are finding things that can be fixed!

peterghaddad avatar May 15 '24 13:05 peterghaddad