ray icon indicating copy to clipboard operation
ray copied to clipboard

[Core] integrate amdsmi in AMDAcceleratorManager

Open vickytsang opened this issue 1 year ago • 1 comments

Why are these changes needed?

Integrate amdsmi library for AMD GPU detection. rocm-smi will be phased out.

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [x] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

vickytsang avatar Apr 08 '24 20:04 vickytsang

Ping me when it's ready for another round of review.

jjyao avatar May 02 '24 22:05 jjyao