ray icon indicating copy to clipboard operation
ray copied to clipboard

Feat/metric validation

Open ujjawal-khare-27 opened this issue 1 year ago • 6 comments

Related issue number

Closes #40586

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [x] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

ujjawal-khare-27 avatar Nov 29 '23 07:11 ujjawal-khare-27

cc @alexeykudinkin can you take a look?

rkooo567 avatar Dec 06 '23 15:12 rkooo567

lint failure seems related

rkooo567 avatar Dec 06 '23 15:12 rkooo567

can you fix lint failure?

rkooo567 avatar Dec 08 '23 14:12 rkooo567

can you fix lint failure?

Will do

ujjawal-khare avatar Dec 08 '23 14:12 ujjawal-khare

@rkooo567 can you merge since you approved?

anyscalesam avatar Feb 09 '24 18:02 anyscalesam

@jjyao can you please help here, I am not sure why these tests are failing.

ujjawal-khare-27 avatar Feb 18 '24 17:02 ujjawal-khare-27

@ujjawal-khare-27 can you rebase and address the comments from @jjyao above?

anyscalesam avatar May 14 '24 19:05 anyscalesam