ray icon indicating copy to clipboard operation
ray copied to clipboard

[RLlib] Use torch's implementation of grad norm clippling

Open avnishn opened this issue 1 year ago • 0 comments

Signed-off-by: avnishn [email protected]

change our grad norm clipping logic to match torch's grad norm clipping function

Why are these changes needed?

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

avnishn avatar Jun 13 '23 19:06 avnishn