ray icon indicating copy to clipboard operation
ray copied to clipboard

Published 20 hours ago • verified publisher icon ray-project

[ci][byod] migrate all data tests to byod

Open can-anyscale opened this issue 1 year ago • 5 comments

Why are these changes needed?

Release test infra now support running tests using anyscale byod, which is a more reliable way of testing.

Migrate all/most data tests to byod

Checks

  • [X] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [X] I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • [X] Unit tests
    • [X] Release tests - https://buildkite.com/ray-project/release-tests-pr/builds/42056 (release tests that fail are already fail on master)

can-anyscale avatar Jun 12 '23 21:06 can-anyscale

On CI, release tests that fail are already fail on master

can-anyscale avatar Jun 13 '23 16:06 can-anyscale

If byod is disabled on pull requests, how are you testing moving data tests to byod?

ollie-iterators avatar Jun 14 '23 15:06 ollie-iterators

If byod is disabled on pull requests, how are you testing moving data tests to byod?

we have means to run tests with wheels and containers that are already built.

aslonnie avatar Jun 14 '23 16:06 aslonnie


via Rota 29 on GIPHY

aslonnie avatar Jun 14 '23 16:06 aslonnie

data folks, @amogkam @bveeramani @raulchen @scottjlee, if you all don't have a strong opinion, I'll merge this PR in sometimes tomorrow on the merit that tests pass after this change. Thankkks

can-anyscale avatar Jun 15 '23 03:06 can-anyscale

@scottjlee: thanks for reviewing Scott. Yesss, some of the tests are currently failing on master so I exclude them until they get fixed first

can-anyscale avatar Jun 16 '23 17:06 can-anyscale