ray icon indicating copy to clipboard operation
ray copied to clipboard

[Serve][Doc] Add Ray Service CR inspection

Open sihanwang41 opened this issue 1 year ago • 4 comments

Why are these changes needed?

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

sihanwang41 avatar Jun 11 '23 23:06 sihanwang41

@edoakes @shrekris-anyscale @zcin please take look,

sihanwang41 avatar Jun 13 '23 16:06 sihanwang41

Hi @akshay-anyscale , can you take a look?

sihanwang41 avatar Jun 14 '23 21:06 sihanwang41

can you rebase with @angelinalg's latest changes

akshay-anyscale avatar Jun 14 '23 23:06 akshay-anyscale

while we are changing this, can you update the example to not use deployment graphs?

akshay-anyscale avatar Jun 14 '23 23:06 akshay-anyscale

while we are changing this, can you update the example to not use deployment graphs?

Currently the deployments are fairly easy. Is there any reasons to change the example?

sihanwang41 avatar Jun 16 '23 20:06 sihanwang41

while we are changing this, can you update the example to not use deployment graphs?

Currently the deployments are fairly easy. Is there any reasons to change the example?

It's because deployment graphs are still in alpha and not very completely supported. We're also moving them down in the documentation

akshay-anyscale avatar Jun 20 '23 02:06 akshay-anyscale

while we are changing this, can you update the example to not use deployment graphs?

Currently the deployments are fairly easy. Is there any reasons to change the example?

It's because deployment graphs are still in alpha and not very completely supported. We're also moving them down in the documentation

Sg, I will go for separate pr to do it.

sihanwang41 avatar Jun 20 '23 15:06 sihanwang41