ray icon indicating copy to clipboard operation
ray copied to clipboard

[Metrics] Fixed metrics with no required tags currently being blackhole'd

Open alexeykudinkin opened this issue 1 year ago • 0 comments

Why are these changes needed?

Currently, Metric implementation requires you to specify tag_keys of the tags that have to be recorded. However it also does NOT allow you to record additional tags on top of the ones you have provided during creation.

This is problematic since it couples metric creation with its usage: you can't, say add new tags to metric usage w/o updating its definition (which might be in a separate module, library, etc)

One straightforward example: if you haven't specified any tag_keys during metric creation it's impossible for you to add any tags during recording.

Proposal:

Treat tag_keys as only a set of required tags (ie allow additional tags to be specified during recording)

Related issue number

N/A

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

alexeykudinkin avatar Jun 10 '23 02:06 alexeykudinkin