ray icon indicating copy to clipboard operation
ray copied to clipboard

[Tune] `bohb_example` patch fix

Open justinvyu opened this issue 2 years ago • 0 comments

Why are these changes needed?

The bohb_example is super flaky after https://github.com/ray-project/ray/pull/35338 modified the example to run more trials. This is just a patch fix to deflake the example. There is still some underlying root cause to investigate. The other BOHB example (the Jupyter notebook) is also flaky, but for a different reason. See https://github.com/ray-project/ray/issues/35428.

Screen Shot 2023-06-08 at 1 39 49 AM

In general, I unsure about the current hyperband implementation. See comments below for parts that I don't really understand.

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

justinvyu avatar Jun 08 '23 08:06 justinvyu