ray icon indicating copy to clipboard operation
ray copied to clipboard

[Tune] Some examples pages are not structured well

Open ArturNiederfahrenhorst opened this issue 1 year ago • 4 comments

Description

Some of our Tune examples look a little weird (example). There is an index at the top with only one entry “Example”.

Also, we dump some output that includes personal folder structure:

Amongst them, this HF page does not render the HF emoji/logo thingy in its title and has two files that are concatenated inside of it but that are not structured to make clear that the second one is ray.tune.examples.pbt_transformers.utils and imported in the first one.

Link

No response

ArturNiederfahrenhorst avatar Jun 07 '23 18:06 ArturNiederfahrenhorst

I'd like to look on this.

SamantaTarun avatar Jun 07 '23 21:06 SamantaTarun

I would like to work upon this

rajveer43 avatar Jun 08 '23 12:06 rajveer43

Thanks for offering to help!

Perhaps @tarunsamanta2k20 can fix up the huggingface example (fix the formatting, and make sure the 2nd file is properly labeled as the imported ray.tune.examples.pbt_transformers.utils, and @rajveer43 you can fix the formatting of the other Tune examples?

justinvyu avatar Jun 08 '23 22:06 justinvyu

Sure @justinvyu , I would love to work on that! Would you tell me where exactly I need to work on?

rajveer43 avatar Jun 09 '23 03:06 rajveer43

Hey @justinvyu and @hora-anyscale, Would you tell me where Exactly I need to work. It would be really helpful

rajveer43 avatar Jun 21 '23 04:06 rajveer43

Hi @rajveer43 , hi @tarunsamanta2k20 ! Thanks for offering your help!

So, I think what you need to work on this is https://docs.ray.io/en/latest/ray-contribute/development.html#building-the-docs (to build the docs and see the effects of your changes). The file that you'd need to change is ray/doc/source/tune/examples/pbt_transformers.ipynb. Asfaics, you'd need to gain an understanding of what the example at hand illustrates and then give the file simple structure that looks tidy and write give a short description about what the user is looking at and how the code snippets in there relate to each other.

ArturNiederfahrenhorst avatar Jun 21 '23 06:06 ArturNiederfahrenhorst

Sure. Can You Help me setting Up they Ray Repo. I have forked and created Venv. Do I Need to Build the Ray and then start working?

rajveer43 avatar Jun 21 '23 06:06 rajveer43

@rajveer43 Thanks! In order to properly develop on Ray (excluding Ray Core parts), please follow the instructions at https://docs.ray.io/en/latest/ray-contribute/development.html#building-ray-python-only

You should fork the repo and checkout master. If you are not on an M1 Mac, you can just install the Ray nightlies in your venv and the link the files to the files in your local clone of your fork with setup-dev, as described in the guide above.

ArturNiederfahrenhorst avatar Jun 22 '23 01:06 ArturNiederfahrenhorst

From there, you can start iterating on your problem by making changes and building the docs to see the effects.

ArturNiederfahrenhorst avatar Jun 22 '23 01:06 ArturNiederfahrenhorst

Please interact with @justinvyu if you have any more questions in the coming days, as I will be on vacation.

ArturNiederfahrenhorst avatar Jun 22 '23 01:06 ArturNiederfahrenhorst

@justinvyu Can you help setting up ray things I did not working.

rajveer43 avatar Jul 04 '23 04:07 rajveer43