ray icon indicating copy to clipboard operation
ray copied to clipboard

[serve][dashboard] Show last line instead of first line in Serve app status message

Open edoakes opened this issue 2 years ago • 3 comments

Typically when there's an error, these status messages include a traceback. That means the last line is the most valuable. Example:

Screen Shot 2023-05-22 at 8 32 47 AM Screen Shot 2023-05-22 at 8 32 55 AM

If the un-expanded version was AttributeError: module 'foo' has no attribute 'bar' I'd know exactly the issue at a glance.

edoakes avatar May 22 '23 13:05 edoakes

@alanwguo @scottsun94 a small UX friction I noticed while dogfooding

edoakes avatar May 22 '23 13:05 edoakes

Also I wonder if there's way to filter out the weird prefix: [36mray::deploy_serve_application()[39m (pid=10048, ip=10.0.12.213)

@zcin thinking about this makes me realize we should do exactly the same exception handling that you did for the replica constructor for the deploy_serve_application task (avoid serialization errors and improve the tracebacks).

edoakes avatar May 22 '23 13:05 edoakes

This P2 issue has seen no activity in the past 2 years. It will be closed in 2 weeks as part of ongoing cleanup efforts.

Please comment and remove the pending-cleanup label if you believe this issue should remain open.

Thanks for contributing to Ray!

cszhu avatar Jun 17 '25 00:06 cszhu