ray icon indicating copy to clipboard operation
ray copied to clipboard

add --node-ip-address tests

Open mattip opened this issue 2 years ago • 2 comments

Why are these changes needed?

The use of node-ip-address and address from the command line is not clearly specified.

  • disallow ray start --node-ip-address since node-ip-address is only for HEAD nodes
  • add tests, including one for ray start --head --address <address:port>

Related issue number

#34094

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

mattip avatar May 14 '23 15:05 mattip

I am not sure ray start --head --address is meant to succeed. Opinions?

mattip avatar May 14 '23 15:05 mattip

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Jun 15 '23 00:06 stale[bot]

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

stale[bot] avatar Aug 11 '23 22:08 stale[bot]