ray icon indicating copy to clipboard operation
ray copied to clipboard

Update core grafana dashboard to use NodeAddress variable in most graphs

Open alanwguo opened this issue 1 year ago • 3 comments

Add NodeAddress to metrics that use "ip" instead to standardize on "NodeAddress" across the board

Why are these changes needed?

Related issue number

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [x] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

alanwguo avatar May 06 '23 02:05 alanwguo

Should we use ray node id?

jjyao avatar May 06 '23 02:05 jjyao

Lmw when it is not a draft anymore!

rkooo567 avatar May 10 '23 01:05 rkooo567

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Jun 10 '23 04:06 stale[bot]

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

stale[bot] avatar Aug 12 '23 05:08 stale[bot]