ray icon indicating copy to clipboard operation
ray copied to clipboard

[core][state] Case insensitive match for string value for state API filter.

Open rickyyx opened this issue 3 years ago • 1 comments

Why are these changes needed?

Ran into an unexpected failure on https://github.com/ray-project/ray/issues/34554, where the query changes as we changes one of the value from (Worker to WORKER)

I think state API filtering could be less strict about case sensitivity, and I feel loosing it altogether would be ok and more usable.

I can hardly think of a usecase where case sensitivity on some fields would be useful. Of course, we could add a flag to the API to toggle this behaviour.

Related issue number

Closes https://github.com/ray-project/ray/issues/34554

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

rickyyx avatar Apr 19 '23 16:04 rickyyx

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Jun 10 '23 04:06 stale[bot]

TODO

rickyyx avatar Jun 12 '23 01:06 rickyyx

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Jul 15 '23 02:07 stale[bot]

Oops this slipped from the GA - @rkooo567 but I feel we could still get this in? Maybe add a change log in the docstring to document this like python does for each function.

rickyyx avatar Jul 17 '23 18:07 rickyyx

yeah I think this makes more sense!

rkooo567 avatar Jul 18 '23 01:07 rkooo567

merge conflict?

rkooo567 avatar Jul 18 '23 01:07 rkooo567

A usability improvement for state API, would be great to get this in. cc @zhe-thoughts

TODO: waiting for test results. Adding test-ok once ready.

rickyyx avatar Aug 25 '23 21:08 rickyyx

@rickyyx @rkooo567 Please get this merged into master first (master is unfrozen for now). Thanks

zhe-thoughts avatar Aug 28 '23 12:08 zhe-thoughts

Test failures unrelated.

rickyyx avatar Aug 29 '23 20:08 rickyyx