ray icon indicating copy to clipboard operation
ray copied to clipboard

Extend ModelCatalog default action distribution to support torch dirichlet distribution

Open MattiasDC opened this issue 2 years ago • 9 comments

The default ModelCatalog.get_action_dist now supports Dirichlet distributions when using the torch framework. This is useful when the Simplex action space is used when using torch.

Why are these changes needed?

Extend the default functionality to support Dirichlet distributions, needed for Simplex action spaces, when using torch.

Related issue number

Closes #32657

Checks

  • [X] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [X] I've run scripts/format.sh to lint the changes in this PR.
  • [] I've included any doc changes needed for https://docs.ray.io/en/master/.
  • [X] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [X] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

MattiasDC avatar Mar 04 '23 18:03 MattiasDC

I'm suspecting some flakyness in the tests here, is there any way I can rerun the tests?

MattiasDC avatar Mar 05 '23 13:03 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Apr 06 '23 00:04 stale[bot]

@sven1977 this has been marked as stale, could someone do a review?

MattiasDC avatar Apr 06 '23 08:04 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar May 08 '23 19:05 stale[bot]

@sven1977 this has been marked as stale, could someone do a review?

MattiasDC avatar May 09 '23 06:05 MattiasDC

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

stale[bot] avatar Jun 10 '23 08:06 stale[bot]

@avnishn, why was this closed? Am I missing a procedure to let this be reviewed?

MattiasDC avatar Jun 10 '23 21:06 MattiasDC

I am terribly sorry we just missed this contribution, but it looks good with me.

avnishn avatar Jun 12 '23 14:06 avnishn

Hi @avnishn , I think the failed tests are flaky, can you confirm and merge if everything is ok?

MattiasDC avatar Jun 13 '23 08:06 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Jul 15 '23 02:07 stale[bot]

@avnishn ?

MattiasDC avatar Jul 15 '23 08:07 MattiasDC