ray icon indicating copy to clipboard operation
ray copied to clipboard
verified publisher icon ray-project

Log an error instead of an info event when the local inference thread of PolicyClient

Open MattiasDC opened this issue 2 years ago • 6 comments

Log an error instead of an info event when the local inference thread of PolicyClient

Why are these changes needed?

Better debug-ability when a crash occurs in the PolicyClient when using the _LocalInferenceThread. If one was running rllib with loglevel 'warning/error/critical', one would miss an exception/crash of the reason, unless the loglevel was 'info'.

Related issue number

Closes #30174

Checks

  • [X] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [X] I've run scripts/format.sh to lint the changes in this PR.
  • [X] I've included any doc changes needed for https://docs.ray.io/en/master/.
  • [X] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [X] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

MattiasDC avatar Mar 04 '23 18:03 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Apr 11 '23 08:04 stale[bot]

Removing stale label, @sven1977 could you have a look?

MattiasDC avatar Apr 11 '23 08:04 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar May 12 '23 12:05 stale[bot]

destaling..

MattiasDC avatar May 12 '23 12:05 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Jun 11 '23 13:06 stale[bot]

Hi @avnishn ,

Could you also give this review a look and merge if ok?

MattiasDC avatar Jun 13 '23 08:06 MattiasDC

Trying another maintainer @krfricke, could you do a review?

MattiasDC avatar Jun 21 '23 07:06 MattiasDC

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Aug 10 '23 04:08 stale[bot]

Removing stale label..

MattiasDC avatar Aug 10 '23 16:08 MattiasDC