ray icon indicating copy to clipboard operation
ray copied to clipboard

Fix cuda docker image references

Open csko opened this issue 2 years ago • 1 comments

Signed-off-by: Kornél Csernai [email protected]

Why are these changes needed?

There is no ubuntu20.04 image for cuda 10.2 and 10.1.

Related issue number

Checks

  • [x] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

csko avatar Jan 02 '23 02:01 csko

Btw, does the build still work with our docker files? (are they compatible with 18.04)?

krfricke avatar Jan 04 '23 10:01 krfricke

Btw, does the build still work with our docker files? (are they compatible with 18.04)?

I'm not super familiar with the build system, but in the 3.11 PR (https://github.com/ray-project/ray/pull/31170) it seemed to work with earlier.

csko avatar Jan 05 '23 02:01 csko

Would you be able to merge this? What's the best way to test this? cc @rickyyx

csko avatar Jan 06 '23 10:01 csko

Interesting - I'm wondering why this doesn't end up with a broken build at the moment.

krfricke avatar Jan 06 '23 10:01 krfricke

Anyway, I'll merge this for now, but we should investigate.

krfricke avatar Jan 06 '23 10:01 krfricke