ray icon indicating copy to clipboard operation
ray copied to clipboard

[Dashboard] Update speedscope from 1.5.3 to the latest 1.13.0

Open mattip opened this issue 3 years ago • 8 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

speedscope is vendored into the dashboard at version 1.5.3 from 2020-1-16. I might be nice ot update it to the latest 1.13.0. Filtering the changelog for relevant improvements, I see improvements in performance, a dark mode, support for retina displays, improvements in labeling, and improvements in search.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

mattip avatar Mar 13 '22 16:03 mattip

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

stale[bot] avatar Jul 13 '22 18:07 stale[bot]

Is the dashboard team interested in updating the speedscope version?

mattip avatar Jul 13 '22 20:07 mattip

Thanks for reporting this! cc @alanwguo for thoughts.

scottsun94 avatar Oct 07 '22 06:10 scottsun94

In the meantime, speedscope 1.14 has been released.

mattip avatar Oct 07 '22 06:10 mattip

I took a quick look at speedscope. It is used for visualizing the profiling info, especially the flamegraphs. I believe it was previously used in the old dashboard for profiling actors?

In Ray 2.0, we made the previous experimental dashboard be the default dashboard. Profiling actors is not supported in it for now. When we work on profiling related features in the new dashboard, this library will be helpful.

scottsun94 avatar Oct 07 '22 17:10 scottsun94

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

stale[bot] avatar Feb 04 '23 20:02 stale[bot]

@alanwguo shall we close it for now?

scottsun94 avatar Feb 05 '23 04:02 scottsun94

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

stale[bot] avatar Jun 10 '23 08:06 stale[bot]

If speedscope is no longer used, perhaps the vendored code from an older version should be removed.

mattip avatar Jun 11 '23 06:06 mattip

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

stale[bot] avatar Oct 15 '23 07:10 stale[bot]