ray
ray copied to clipboard
[Bug] Remove requests from minimal deps CI test from miniconda
Search before asking
- [X] I searched the issues and found no similar issues.
Ray Component
Ray Core
What happened + What you expected to happen
we have implicit dependencies issue that we actually uses requests
module in our minimal test, even though it appeared in the blacklisted module list but commented out inline. As I followed up with Kai, miniconda comes with requests
bundled by default.
As a result our CI would pass given the fact that it has requests
module installed but will fail if we enforce the actual minimal CI test setup without it.
I think proper follow up is either 1) We make it clear to add requests
module back to minimal install and remove it from module blacklist or 2) remove requests
module completely from miniconda. Either way will bring us back to consistency, and i will consider 2) more favorable and can follow up on
Versions / Dependencies
master
Reproduction script
.
Anything else
No response
Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
Hi, I'm a bot from the Ray team :)
To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.
If there is no further activity in the 14 days, the issue will be closed!
- If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
- If you'd like to get more attention to the issue, please tag one of Ray's contributors.
You can always ask for help on our discussion forum or Ray's public slack channel.
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.
Please feel free to reopen or open a new issue if you'd still like it to be addressed.
Again, you can always ask for help on our discussion forum or Ray's public slack channel.
Thanks again for opening the issue!