kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard

Published 20 hours ago • verified publisher icon ray-project

[logger] sync to file

Open Basasuya opened this issue 2 years ago • 1 comments

Why are these changes needed?

support sync log to file in pod. this feature is controllered by log_file parameter in command line, default only output log to std

Related issue number

https://github.com/ray-project/kuberay/issues/593

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [x] Manual tests
    • [ ] This PR is not tested :(

Basasuya avatar Oct 13 '22 08:10 Basasuya

manual testing through replace the based image in dockerfile. the previous image can not exec into it.

Basasuya avatar Oct 13 '22 09:10 Basasuya

Overall the change looks good to me beside the parameter pattern

Jeffwan avatar Oct 18 '22 16:10 Jeffwan

@Basasuya can you help address @kevin85421's comment?

Jeffwan avatar Oct 20 '22 18:10 Jeffwan

@kevin85421 sorry for the slow reply, I have rebase the master again.

Basasuya avatar Oct 28 '22 04:10 Basasuya

Can you add more details about how to use this feature in your PR description? This PR will be very helpful for both users and developers to debug. Thank you! Overall, the code looks good to me, and I just added some nit comments on it.

I add the detail in PR description.

Basasuya avatar Oct 31 '22 07:10 Basasuya

@Jeffwan is this PR ready to merge? The merge is blocked by your change requests. Thank you!

kevin85421 avatar Oct 31 '22 18:10 kevin85421

@kevin85421 Yeah, it looks good to me.

Jeffwan avatar Nov 01 '22 03:11 Jeffwan