kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard

[Feature] [apiserver] Support custom cluster/pod annotations in KubeRay apiserver

Open dhaval0108 opened this issue 3 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

While creating a ray cluster using KubeRay apiserver (via the POST apis/v1alpha2/namespaces/namespace_name/clusters endpoint), there is no support to add custom annotations. These annotations are sometimes required by users to integrate with their respective in-house solutions.

Use case

My team needs to add custom annotations so that the ray cluster can have access to Vault, our secret management service.

Related issues

None

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

dhaval0108 avatar Oct 10 '22 16:10 dhaval0108

We have similar requirements in downstream and we extend a field to support it. Feel free to take this story!

Jeffwan avatar Oct 11 '22 04:10 Jeffwan

Thanks @Jeffwan, could you please share more details about your implementation?

dhaval0108 avatar Oct 26 '22 23:10 dhaval0108

Its done

blublinsky avatar Nov 17 '23 08:11 blublinsky