kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard

Init dashboardClientFunc and httpProxyClientFunc by the config arg

Open bugorz opened this issue 1 year ago • 3 comments

Why are these changes needed?

  • Based on @kevin85421's suggestion at https://github.com/ray-project/kuberay/pull/1980#discussion_r1550243563
  • Instead of passing function(s) to NewRayServiceReconciler and NewRayJobReconciler, initialing them by the v1alpha1.Configuration configuration

Related issue number

  • https://github.com/ray-project/kuberay/pull/1980

Checks

  • [x] I've made sure the tests are passing.
  • Testing Strategy
    • [] Unit tests
    • [x] Manual tests
    • [ ] This PR is not tested :(

bugorz avatar Apr 21 '24 06:04 bugorz

cc @rueian @kevin85421

bugorz avatar Apr 21 '24 06:04 bugorz

LGTM

rueian avatar Apr 21 '24 08:04 rueian

@kevin85421, This is our friend Sean's first contribution to KubeRay. Please take a look when you are available.

rueian avatar Apr 21 '24 08:04 rueian

Thanks @kevin85421 for the guidance.

hsiang-c avatar May 08 '24 08:05 hsiang-c