kuberay
kuberay copied to clipboard
Init dashboardClientFunc and httpProxyClientFunc by the config arg
Why are these changes needed?
- Based on @kevin85421's suggestion at https://github.com/ray-project/kuberay/pull/1980#discussion_r1550243563
- Instead of passing function(s) to
NewRayServiceReconcilerandNewRayJobReconciler, initialing them by thev1alpha1.Configurationconfiguration
Related issue number
- https://github.com/ray-project/kuberay/pull/1980
Checks
- [x] I've made sure the tests are passing.
- Testing Strategy
- [] Unit tests
- [x] Manual tests
- [ ] This PR is not tested :(
cc @rueian @kevin85421
LGTM
@kevin85421, This is our friend Sean's first contribution to KubeRay. Please take a look when you are available.
Thanks @kevin85421 for the guidance.