kuberay icon indicating copy to clipboard operation
kuberay copied to clipboard

[Feature] Should we stop publishing images on DockerHub?

Open kevin85421 opened this issue 1 year ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

KubeRay CI publishes images to both Quay and DockerHub. However, the DockerHub bot has somehow been removed from the KubeRay DockerHub account, causing KubeRay CI to fail when pushing images to DockerHub. To unblock it, I opened #1923 and #1926 as a workaround.

I have already decided to use Quay as the default image registry for KubeRay v1.1.0 because (1) it doesn't have pull limit (2) it has more usage log. Therefore, I am currently considering whether we should still publish images on DockerHub or not.

Any thoughts? cc @andrewsykim @astefanutti @anishasthana

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

kevin85421 avatar Feb 17 '24 04:02 kevin85421

+1

It'd be useful to have a warning in the release notes so existing users can adjust their existing deployment if needed.

astefanutti avatar Feb 19 '24 08:02 astefanutti

I'm a +1 to this as well but perhaps we should stagger it a release? At least to give users some time to adjust.

anishasthana avatar Feb 19 '24 20:02 anishasthana

No objections to make quay the default and to stop publishing nighlty images through CI. But do we really have to remove dockerhub support entirely? Can we still publish to dockerhub only on tagged releases?

andrewsykim avatar Feb 20 '24 15:02 andrewsykim

Thank you for the feedback! I will try to reach out to our CI/Security teams to set it up the DockerHub back, but I think it may be a long process.

kevin85421 avatar Feb 20 '24 23:02 kevin85421