ray-project
[Doc] Deprecate `ServiceUnhealthySecondThreshold` and `DeploymentUnhealthySecondThreshold`
As per https://github.com/ray-project/kuberay/pull/1664 and https://github.com/ray-project/kuberay/pull/1665, the latest kuberay operator will not respect DeploymentUnhealthySecondThreshold and ServiceUnhealthySecondThreshold fields at all.
Ideally, we should inform users that these fields are deprecated, and we thought that the kubebuilder could do this for us by using the +kubebuilder:deprecatedversion marker. However, it turns out that this marker doesn't work for us because it only works at the CRD root level, and no similar marker works at the field level.
Here, in this issue, I'd like to discuss alternatives to kubebuilder code generation:
- Deprecate these fields in our go source code.
- Deprecate or hide these fields in the generated document.
- Emit warning messages as kubernetes event when these fields are set by users.
- Use validation webhook to return warnings. This will introduce new complexity for installing and maintaining the webhook.
I believe the first option is trivial, and the second option is a must.
How about the third and the fourth? Are they good to have?
cc @kevin85421
