deltacat icon indicating copy to clipboard operation
deltacat copied to clipboard

Restructure deltacat metrics to allow for decorators

Open yankevn opened this issue 2 years ago • 1 comments

This change restructures deltacat's metrics code to allow for metrics emission via decorator functions. To accomplish this, the MetricsConfigSingleton class is introduced to make the metrics_config object globally available while enforcing immutability as much as possible.

Testing:

  • pytest
  • Tested on personal stack and verified metrics were created

yankevn avatar Oct 24 '23 18:10 yankevn

Performance test IM results (3 runs each): With changes: [271369, 271709, 260248] Without changes: [278824, 283523, 277561]

If anything this seems to show that the changes are more efficient for whatever reason.

yankevn avatar Oct 30 '23 23:10 yankevn

Resolved by #294

raghumdani avatar May 07 '24 19:05 raghumdani