Block-Site icon indicating copy to clipboard operation
Block-Site copied to clipboard

Please increase the filter amount limit

Open GreatestFool opened this issue 2 years ago • 4 comments

Only today did it start complaining that I have too many filters, although there are 500, there has been no issues with blocking up to this point. If there is a reason for this change, it'd be nice to know why exactly, but preferably this change can be rolled back or changed to accommodate larger filter lists.

GreatestFool avatar Jul 26 '22 17:07 GreatestFool

Can you share the preferences in JSON format?

ray-lothian avatar Jul 27 '22 12:07 ray-lothian

I need the list to test the performance. The feature releases will use declarativeNetRequest on Firefox and there is a limit here; https://developer.chrome.com/docs/extensions/reference/declarativeNetRequest/#property-MAX_NUMBER_OF_REGEX_RULES

ray-lothian avatar Jul 27 '22 12:07 ray-lothian

If you're worried about performance and don't really have time to test extensively or to a degree that you'd prefer, being able to arbitrarily set the MAX_NUMBER_OF_REGEX_RULES in the settings would be nice. Leaving it between a range of 1 to 5000 with a reasonable default is okay, but it'd be nice to have a value to allow infinite. A small warning or similar next to the setting or when exceeding a recommended value can help deter people who don't actually need that many from enabling it.

Preferences

The settings are nothing special. I've removed the blocked sites to keep the file small, because they aren't really necessary here, when it's just a lot of regular blocking. I've removed the GUID too for this upload, even though it's not necessary, in case you're wondering why it is missing.

{
  "blocked": [],
  "close": 0,
  "contextmenu-frame": false,
  "contextmenu-pause": false,
  "contextmenu-resume": true,
  "contextmenu-top": false,
  "crate": 4,
  "css": "",
  "guid": "",
  "initialBlock": true,
  "last-update": 1658852887671,
  "managed.storage.overwrite.on.start": false,
  "map": {},
  "message": "",
  "no-password-on-add": true,
  "redirect": "https://i.redd.it/1wbz4b15vcd31.jpg",
  "reverse": false,
  "schedule": {
    "times": {}
  },
  "schedule-offset": 0,
  "schedules": {},
  "sha256": "",
  "timeout": 60,
  "title": true,
  "wrong": 1
}

GreatestFool avatar Jul 27 '22 23:07 GreatestFool