Block-Site icon indicating copy to clipboard operation
Block-Site copied to clipboard

feat: Updated UI

Open alexandrtovmach opened this issue 4 years ago • 6 comments

Thank you for your amazing extension, here UI updates for the configuration page (because it looks very poor, and it's scare potential users). I decided to help with that, and here we go!

image

DRAFT: Don't merge this PR, I need to investigate about modal functionality

alexandrtovmach avatar Mar 02 '20 10:03 alexandrtovmach

True, the options page needs a new look. Note that we cannot load remote resources and it is not recommenced to customize elements on the options page. There are many different browsers and each has its styling.

Let me work on the option's UI based on your suggestions. You can modify the new design.

ray-lothian avatar Mar 03 '20 08:03 ray-lothian

Could you provide me with a link to limitations of extensions styling, to not waste time for me, thanks

alexandrtovmach avatar Mar 03 '20 08:03 alexandrtovmach

From my quick experience with it, all button color styling and modal window blocking by some policy

alexandrtovmach avatar Mar 03 '20 08:03 alexandrtovmach

It is not allowed to have remote resources in your extension. Even if the policy is not blocking it, the extension will get rejected due to privacy concerns.

Could you provide me with a link to limitations of extensions styling, ...

It is not a limitation. It is more of having the options page of all extensions looks similar to the users of the browser. You can definitely overwrite all the browser's styles, but for such a simple options page it is not recommended. btw, I am trying to rewrite some parts to make it more intuitive rather than just restyling.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles

ray-lothian avatar Mar 03 '20 10:03 ray-lothian

I was about to create a pull request that added

  "options_close_blocked": {
    "message": "Close after (seconds):"
  },

That's probably not worth it if this is coming any time soon?

greenfox1505 avatar Apr 15 '20 17:04 greenfox1505

@greenfox1505 to add the (seconds) part? https://github.com/ray-lothian/Block-Site/commit/6255a38b0cee611c38f210cb5fd454cf392c0bf4

ray-lothian avatar Apr 16 '20 06:04 ray-lothian