muffet icon indicating copy to clipboard operation
muffet copied to clipboard

Clean up deprecated arguments

Open vsupalov opened this issue 10 months ago • 2 comments

Close #300.

There is a bit of uncertainty. I'm not sure if I understood your intention with deprecating the sitemap flag - my guess is, that the functionality is intended be removed.

If that interpretation is correct, I will add some refactoring to the PR, to make sure the now-unnecessary sitemap related remnants are cleaned up.

vsupalov avatar Apr 23 '24 17:04 vsupalov

Thank you for the changes! I'm gonna review this soon.

raviqqe avatar Apr 24 '24 07:04 raviqqe

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v3@0b34fcf). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v3     #380   +/-   ##
=====================================
  Coverage      ?   88.68%           
=====================================
  Files         ?       33           
  Lines         ?      716           
  Branches      ?        0           
=====================================
  Hits          ?      635           
  Misses        ?       60           
  Partials      ?       21           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 24 '24 07:04 codecov[bot]

Closing the PR for the sake of cleanup. Feel free to use the code!

vsupalov avatar Aug 28 '24 13:08 vsupalov